Skip to content

feat: improve error messages for annotation issues in command parameters #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 18, 2025
Merged

feat: improve error messages for annotation issues in command parameters #1411

merged 6 commits into from
Oct 18, 2025

Conversation

@onerandomusername
Copy link
Member

Reduce the length of the traceback and provide a helpful error message
when a user forgets to import a type used in a command parameter annotation
outside of a TYPE_CHECKING block.

@onerandomusername
feat: improve error messages for annotation issues in command parameters
ad9a27c 
Reduce the length of the traceback and provide a helpful error message
when a user forgets to import a type used in a command parameter annotation
outside of a TYPE_CHECKING block.
@onerandomusername onerandomusername added the s: needs review Issue/PR is awaiting reviews label Sep 30, 2025
@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 30, 2025 •
edited
Loading

Documentation build overview

📚 disnake | 🛠️ Build #29991028 | 📁 Comparing 17a2f65 against latest (a26c681)


🔍 Preview build

Show files changed (48 files in total): 📝 48 modified | ➕ 0 added | ➖ 0 deleted
File Status
index.html 📝 modified
whats_new.html 📝 modified
api/abc.html 📝 modified
api/activities.html 📝 modified
api/app_commands.html 📝 modified
api/app_info.html 📝 modified
api/audit_logs.html 📝 modified
api/automod.html 📝 modified
api/channels.html 📝 modified
api/clients.html 📝 modified
api/components.html 📝 modified
api/emoji.html 📝 modified
api/entitlements.html 📝 modified
api/events.html 📝 modified
api/exceptions.html 📝 modified
api/guild_scheduled_events.html 📝 modified
api/guilds.html 📝 modified
api/integrations.html 📝 modified
api/interactions.html 📝 modified
api/invites.html 📝 modified
api/localization.html 📝 modified
api/members.html 📝 modified
api/messages.html 📝 modified
api/misc.html 📝 modified
api/permissions.html 📝 modified
api/roles.html 📝 modified
api/skus.html 📝 modified
api/soundboard.html 📝 modified
api/stage_instances.html 📝 modified
api/stickers.html 📝 modified
api/subscriptions.html 📝 modified
api/ui.html 📝 modified
api/users.html 📝 modified
api/utilities.html 📝 modified
api/voice.html 📝 modified
api/webhooks.html 📝 modified
api/widgets.html 📝 modified
ext/tasks/index.html 📝 modified
ext/commands/api/app_commands.html 📝 modified
ext/commands/api/bots.html 📝 modified
ext/commands/api/checks.html 📝 modified
ext/commands/api/cogs.html 📝 modified
ext/commands/api/context.html 📝 modified
ext/commands/api/converters.html 📝 modified
ext/commands/api/exceptions.html 📝 modified
ext/commands/api/help_commands.html 📝 modified
ext/commands/api/misc.html 📝 modified
ext/commands/api/prefix_commands.html 📝 modified

@onerandomusername onerandomusername added p: medium Medium priority t: enhancement New feature labels Sep 30, 2025
@onerandomusername onerandomusername self-assigned this Sep 30, 2025
shiftinv
shiftinv reviewed Oct 12, 2025
View reviewed changes
shiftinv
shiftinv reviewed Oct 18, 2025
View reviewed changes
onerandomusername and others added 2 commits October 18, 2025 05:13
@onerandomusername @shiftinv
Update changelog/1411.feature.rst
8ccfe05 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Zenith <me@arielle.codes>
@onerandomusername
Merge branch 'master' into qt/improve-annotation-errors
17a2f65
@shiftinv shiftinv merged commit f7374b7 into master Oct 18, 2025
38 checks passed
@shiftinv shiftinv deleted the qt/improve-annotation-errors branch October 18, 2025 09:38
@shiftinv shiftinv mentioned this pull request Oct 18, 2025
Merged
@onerandomusername onerandomusername added this to the disnake v2.12 milestone Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees

@onerandomusername onerandomusername

Labels

p: medium Medium priority s: needs review Issue/PR is awaiting reviews t: enhancement New feature

Projects

None yet

Milestone

disnake v2.12

Development

Successfully merging this pull request may close these issues.

2 participants

@onerandomusername @shiftinv